fix!: Only resolve the first DNS-like component #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
requested changes
Oct 1, 2024
sukunrt
approved these changes
Oct 1, 2024
|
Panics should be reserved for cases where you don't know what to do next and the best option is to stop the program. Returning an empty list for a nil address seems reasonable to me and seems better than stopping the program. |
BREAKING CHANGE: Previously Resolve would resolve all DNS components in a multiaddr. Now it will only resolve the first one. Users may iteratively call Resolve to get the old behavior. See the tests for an example.
MarcoPolo
force-pushed
the
marco/limit-resolve
branch
from
7f0b4b4
to
67d5a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know, the ability to resolve multiple DNS addresses isn't used. This removes that ability for the simpler approach of just resolving the first DNS component in the multiaddr
BREAKING CHANGE: Previously Resolve would resolve all DNS components in a multiaddr. Now it will only resolve the first one. Users may iteratively call Resolve to get the old behavior. See the tests for an example.