Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DropDownMenu] menu width doesn't fit when props changed. #805

Closed
iamzhouyi opened this issue Jun 10, 2015 · 3 comments
Closed

[DropDownMenu] menu width doesn't fit when props changed. #805

iamzhouyi opened this issue Jun 10, 2015 · 3 comments
Labels
component: menu This is the name of the generic UI component, not the React module!

Comments

@iamzhouyi
Copy link

Refer to #203 I'v found the height is able to adjust when items changed. However the width got same issue with it. And it can't just set a fixed width of style to avoid.
@velveteer velveteer mentioned this issue Jun 11, 2015
Closed
@hai-cea hai-cea changed the title menu width doesn't fit when props changed. [DropDownMenu] menu width doesn't fit when props changed. Jun 19, 2015
@hai-cea hai-cea mentioned this issue Jun 25, 2015
Closed
@rolandpoulter
Copy link
Contributor

Height calculations are not working still.
image

I have a fix for this, the problem is that I have a MenuItem.Types.SUBHEADER menu item. And its height is not the same as a normal menu item.

@rolandpoulter rolandpoulter mentioned this issue Jul 1, 2015
Merged
@rolandpoulter
Copy link
Contributor

image

@rolandpoulter rolandpoulter mentioned this issue Jul 1, 2015
Merged
@hai-cea
Copy link
Member

hai-cea commented Jul 13, 2015

Fixed with #1014

@hai-cea hai-cea closed this as completed Jul 13, 2015
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: menu This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rolandpoulter @hai-cea @oliviertassinari @iamzhouyi @zannager