Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE Support (I hate to ask this) #468

Closed
roboto84 opened this issue Mar 27, 2015 · 26 comments
Closed

IE Support (I hate to ask this) #468

roboto84 opened this issue Mar 27, 2015 · 26 comments
Labels
docs Improvements or additions to the documentation

Comments

@roboto84
Copy link

Ok, I hate to be that guy, but I can't see anyone on the issues that has asked the IE support question. So here it is. Does this awesome framework have any support for the bastard children (IE9, IE10, & IE11). If so, how good is it? I just tried to pull up (http://callemall.github.io/material-ui/#/) on an IE9 VM and IE10 VM. It could not even load the page. Does anyone else have this on their radar, or have any input on this? Do I require polyfills? If so which? If there are any docs on browser support, please point me towards them.

I would like to use this framework, but the overlords are concerned with IE support, so I must be as well. Anyway, regardless of this, awesome job. Hopefully I can use this at some point in time. Thanks in advance for any input.

@m-spec
Copy link

m-spec commented Mar 31, 2015

Same story here. IE support (9, 10, 11) is unfortunately quite vital for us so it would be nice to get some clarification to this issue.

@natelaws
Copy link

Didn't dig to far into this, but looking at ie10 it looks like just doing toString.call() doesn't work. http://stackoverflow.com/questions/19321938/invalid-calling-object-error-in-ie

The issue is triggered in places like this. https://github.com/callemall/material-ui/blob/master/src/js/app-bar.jsx#L50

@Thr1ve
Copy link
Contributor

Thr1ve commented Apr 2, 2015

Possibly related Issue from Bootstrap-Tour: sorich87/bootstrap-tour#214

@majodev
Copy link

majodev commented Apr 8, 2015

IE11 looks good for me if toString.call() in dialog.jsx:24 and app-bar.jsx:50 get's replaced with Object.prototype.toString.call().

@mmrtnz
Copy link
Contributor

mmrtnz commented Apr 8, 2015

Hey everyone! @hai-cea might know more information about IE support, so I'll leave it to him to answer in more detail. In the mean time, I'll submit a pull request to fix the toString.call() issue.

@mikesimkin
Copy link

Found a several issues in IE11:

  • Sliders don't move
  • Switches styling is misaligned and the ripple effect is wrong
  • Font looks really bad

@platphorm
Copy link

I'm curious. I would imagine the type of clientele call-em-all has (churches, schools...) would make IE support a high priority. Is this not the case?
We would like to use MUI but need to get a sense of whether IE 10/11 issues are important to the community or not

@goldbergyoni
Copy link

Does MUI basically works in IE10?

@aweary
Copy link
Contributor

aweary commented Oct 19, 2015

@hai-cea @mmrtnz It'd be great to get some clarification on browser support.

@peteringram0
Copy link

As far as i can see 90% of components work fine in IE9. However it look like nothing will work on IE8.

I think i would use this for projects that don't require IE8

As far as @mikesimkin comments, sliders seem to work fine on IE9 and IE10 however they are jumpy (Not an issue if the user is on IE they are used to it) Also switches do work but again its not going to be nearly as smooth as a good browser.

@alitaheri alitaheri added this to the Cross browser support milestone Dec 8, 2015
@alitaheri alitaheri added new feature New feature or request and removed Enhancement labels Dec 8, 2015
@alitaheri alitaheri added Cross Browser Support and removed new feature New feature or request labels Dec 22, 2015
@alitaheri alitaheri modified the milestone: Cross browser support Dec 22, 2015
@andrewmclagan
Copy link

any movement on this? without an offical specification im guessing allot of projects cannot use this library

@mbrookes
Copy link
Member

The answer is, Material-UI is moving towards using flex internally, so any browser that supports that is a target. In addition, MS have dropped support for IE < 11, and we have followed suit. (Global usage of IE10 = 0.63%*)

*http://caniuse.com/#search=flex

I'll make this a docs issue - just need to figure out the best place to put it. 😄

@mbrookes mbrookes added the docs Improvements or additions to the documentation label Mar 15, 2016
@nathanmarks
Copy link
Member

Just to add -- we will have a higher focus on cross browser compatibility (where we can with the tech we're choosing to use) once we reach 1.0

@andrewmclagan
Copy link

thank you MS... thank you so very much :-)

@sontek
Copy link

sontek commented May 23, 2016

Where can we find list of current supported(tested) browsers? Need to know if we can adopt this or not :)

@mbrookes
Copy link
Member

@sontek I would take this to be the defacto list: http://caniuse.com/#feat=flexbox

Some components will work with older browsers, but that isn't guaranteed in future versions as we continue to adopt flexbox.

@sontek
Copy link

sontek commented May 23, 2016

@mbrookes Yeah, the reason I asked was because of flexbox. As you can see from that page you linked there is no version of IE that implements flexbox properly and so I'm wondering if you are explicitly saying IE will not be supported or if you'll at least be supporting IE and working around their flexbox bugs.

@mbrookes
Copy link
Member

@sontek IE 11 is the only version of IE supported by Microsoft on Windows desktop, and that version has enough flexbox support that Material-UI should work fine. If it it doesn't, you can probably consider that a bug, as I don't believe there's anything on the "Known issues" list that list we can't work around.

@aahan96
Copy link
Contributor

aahan96 commented Jun 14, 2016

@mauricio28 Can we close this issue?

@sontek
Copy link

sontek commented Jun 14, 2016

I wouldn't close it without updating the docs to describe what @mbrookes said above. "IE 11 is the only version we will be supporting" or something like that. This is definitely a developers point of view and not a pragmatic view of the actual usage of each browser but if thats what the project is going to do then they should document it or more people will just re-open or recreate this ticket.

@mbrookes
Copy link
Member

This is definitely a developers point of view and not a pragmatic view of the actual usage of each browser

[citation needed] 😄

http://caniuse.com/#feat=flexbox 94% of browsers support flexbox.

It's a tradeoff for sure, but supporting a browser that the browser vendor doesn't is an uphill battle that we don't have the resources for as a volunteer team.

if thats what the project is going to do then they should document it

Please submit a PR for that.

@andrewmclagan
Copy link

A minimum browser support of IE11 is ok when considering normal demographics such as http://caniuse.com. Although IE9, IE10 and IE11 have large usage spikes during office hours.

@hhaidar
Copy link

hhaidar commented Jul 8, 2016

@nathanmarks @oliviertassinari we've found some text overlap issues in TextField with IE9. It's because translate3d is not supported. Would you guys be alright with switching to regular translate?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 8, 2016

@hhaidar I'm wondering why we actually use translate3d?

  • That's promoting the floating label into his own layer, but, is this a good idea?
    Well, that doesn't sound like a bad tradeoff.
    I think that we should use will-change in that case.
  • For the perspective(1px)? I haven't tested the impact but I feel that we can remove it.

@hhaidar
Copy link

hhaidar commented Jul 8, 2016

@oliviertassinari yea seems to look at the same without translate3d/perspective, I'll open a PR in a bit.

@mbrookes
Copy link
Member

Closing in favor of #1865.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests