Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] IndeterminateIcon is Missing From Checkbox Docs #43499

Open
jwalkerinterpres opened this issue Aug 28, 2024 · 6 comments · May be fixed by #43791
Open

[docs] IndeterminateIcon is Missing From Checkbox Docs #43499

jwalkerinterpres opened this issue Aug 28, 2024 · 6 comments · May be fixed by #43791
Assignees
Labels
component: checkbox This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. support: docs-feedback Feedback from documentation page

Comments

@jwalkerinterpres
Copy link

jwalkerinterpres commented Aug 28, 2024

Related page

https://mui.com/material-ui/react-checkbox/

Kind of issue

Missing information

Issue description

See #43415

Telling people about how a library works in issue replies is not ideal: the prop should be documented (on the main Checkbox UI docs page).

Also it's worth noting that the API docs mention indeterminate icon ... but even they don't say anything about having to use indeteriminateIcon to avoid an SVG glitch if you use a custom checkbox.

Context

Trying to use an indeterminate checkbox with a custom checked icon.

Search keywords: indeterminate checkbox

@jwalkerinterpres jwalkerinterpres added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Aug 28, 2024
@siriwatknp siriwatknp added component: checkbox This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 29, 2024
@siriwatknp
Copy link
Member

Thanks for the feedback! I agree with you. There should be a section explaining that you could replace the intermediate icon.

@Nipun-Milinda
Copy link

Hi @siriwatknp,

Thanks for acknowledging the feedback on the Checkbox component documentation! I'd like to contribute by adding the missing details about the indeterminateIcon prop and how to avoid the SVG glitch when using a custom checkbox.

I'll include a section explaining the proper usage and provide a code example to make it clearer for others. Let me know if there are any specific guidelines or additional points you'd like me to cover.

Looking forward to your response!

@marctaylor01
Copy link

Hi!

My name is Marc, and I’m excited to start contributing to MUI!

I’m new to open-source, but I have experience with React and the use of MUI, and I’m eager to learn more and help out where I can. I’ve gone through the contribution guidelines and am currently looking at some issues labeled “good first issue.”

I’d love to hear any advice on where to start and I was wondering if this Issue is available to take?

Thanks!

@marctaylor01
Copy link

I'll start working on this issue, @siriwatknp could you assign me this issue please?

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Sep 17, 2024

Also it's worth noting that the API docs mention indeterminate icon ... but even they don't say anything about having to use indeterminateIcon to avoid an SVG glitch if you use a custom checkbox.

Can you show an example in the form of a reproduction where the SVG glitch is occurring?

@aarongarciah aarongarciah self-assigned this Sep 17, 2024
@jwalkerinterpres
Copy link
Author

jwalkerinterpres commented Sep 17, 2024

If you look at the original ticket (linked above) you'll see I added a code sandbox link ... but (for some odd reason) the styling showing the issue got left out 😦

But, you can still see the issue there, if you just modify the checkbox to add a style line, like so:

<Checkbox
    checked={checked[0] && checked[1]}
    indeterminate={checked[0] !== checked[1]}
    onChange={handleChange1}
    style={{ fill: "red", stroke:'red', background: "black" }}
/>

The original ticket also has an image showing the extra (SVG-based, not CSS) "border" that you should see with that line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: checkbox This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. support: docs-feedback Feedback from documentation page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants