Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable style API? #27698

Closed
cristianoccazinsp opened this issue Aug 11, 2021 · 1 comment
Closed

Stable style API? #27698

cristianoccazinsp opened this issue Aug 11, 2021 · 1 comment
Labels
duplicate This issue or pull request already exists v5.x

Comments

@cristianoccazinsp
Copy link

Hello,

I really appreciate the work and effort put into this library. I've been using it since version 1 (I think), and it has always been great. However, you guys keep changing the styling API on every version! I don't know how many times I had to do massive code migrations in order to keep up with the updates, yet every new version introduces a million breaking changes.

Are you guys ever going to stay with a stable API? Every update is dreadful, so many breaking changes. Version 4 withStyles and makeStyles is great, flexible, and very easy to understand. Version 5 styling solution seems more complicated and difficult to use, not to mention the code refactor to migrate to it is huge! Are you guys sure you won't change it yet again in version 6?

Not a complaint, just wanted to know the rationale behind so many breaking changes on every version.

@cristianoccazinsp cristianoccazinsp added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 11, 2021
@eps1lon
Copy link
Member

eps1lon commented Aug 12, 2021

Thanks for the feedback.

Breaking changes are not taken lightly. We usually have a strong rationale for larger breaking changes or easy migration paths (e.g. codemod) for smaller breaking changes. All of these breaking changes are described in our migration guide and announced in advance in #20012 (which is also pinned in this repository).

Are you guys ever going to stay with a stable API?

Like everything else, the web advances over time and better solution for older problems (or even new problems) are discovered. Sometimes these new solutions require breaking changes. Every breaking change should improve the library overall. If you want to focus on stability then you can always stay on the current version. These versions are not removed from the web.

Not a complaint, just wanted to know the rationale behind so many breaking changes on every version.

The rationale is described in detail in #22342

Closing since the discussion should either happen in #20012 or #22342

@eps1lon eps1lon closed this as completed Aug 12, 2021
@eps1lon eps1lon added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists v5.x
Projects
None yet
Development

No branches or pull requests

3 participants