Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5alpha LoadingButton rename to PendingButton? #21906

Closed
tomByrer opened this issue Jul 24, 2020 · 7 comments
Closed

v5alpha LoadingButton rename to PendingButton? #21906

tomByrer opened this issue Jul 24, 2020 · 7 comments
Labels
component: button This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists

Comments

@tomByrer
Copy link

I just used the LoadingButton to be a Submit button that will not become active until the user fills the form. IMHO better UX than having an active Submit button that tempts you to push it when you're not supposed to ;)

So because your new button is can be great outside of just loading, perhaps a wider name like PendingButton or StatusButton could broaden its use..

@tomByrer tomByrer added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 24, 2020
@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 24, 2020
@oliviertassinari
Copy link
Member

Duplicate of #21593

@oliviertassinari oliviertassinari marked this as a duplicate of #21593 Jul 24, 2020
@tomByrer
Copy link
Author

Sorry @oliviertassinari I was not clear; my suggestion is for <PendingButton /> vs <LoadingButton />

The linked suggestion is for the prop pending etc.

Can you please reopen & reconsider?

@oliviertassinari
Copy link
Member

The concern is identical, shouldn't we rename the component too for consistency with the name of the prop?

@tomByrer
Copy link
Author

Good question!

My vision for your cool button is to use for any 'not ready' status, which includes:

  • uploading
  • downloading
  • waiting for user input (forms, ULA, CAPTCHA, etc)
  • processing (WebWorkers, remote processing, etc)

These are all 'pending' uses, but not all 'loading'.

Here's a 7 second demo of my use-case.
https://tombyrer.tinytake.com/tt/NDQ4MzkwOF8xNDE5NzA0MQ

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 24, 2020

Here's a 7 second demo of my use-case.

For this use case, prefer leaving the button pristine. We encourage end-users to be able to validate the form and trigger the validation errors, rather than starting with the button disabled.

@tomByrer
Copy link
Author

I understand.

How do you feel about waiting for computational processioning?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 24, 2020

How do you feel about waiting for computational processioning?

Pending for the name of the state would better match what's going on. Note that in 80% of the time (I don't have any proof other than my experience building and using applications), what's pending is a network request.

IMHO the whole tradeoff is about what's more accurate vs what are developers more likely to find, expect, query. The balance is leaning toward the latter.

I'm locking the issue, it's a duplicate of the one linked.

@mui mui locked as resolved and limited conversation to collaborators Jul 24, 2020
@oliviertassinari oliviertassinari added the component: button This is the name of the generic UI component, not the React module! label Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: button This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants