[Hidden] Remove component

[fromi]

• The issue is present in the latest release.
• I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

The Hidden component documentation states: "Any other props supplied will be provided to the root element (native element)." (see https://material-ui.com/api/hidden/)
However, the typescript declaration file for the component does not declare all the native underlying div properties, and the properties are not passed down, except for the className (which is not declared anyway for typescript users).
I use the CssHidden implementation of the component.

Expected Behavior 🤔

I should be able to add custom styles to the underlying div element using className or style properties.

Steps to Reproduce 🕹

Very simple: create a typescript project, use <Hidden mdUp implementation="css" className="whatever">, it does not compile.

Context 🔦

I want to add custom style to the div element generated by the Hidden component, using either className or style property (I need height="100%" at each level here).

I made this workaround for now:

const FixHidden = Hidden as React.ComponentType<HiddenProps & {className: string}>

[eps1lon]

I don't have the full history for this component. For HiddenCSS we could spread the props to the div. However, the types need to reflect that only <Hidden implementation="css" /> supports this. <Hidden implementation="js" /> does not support this.

[fromi]

That's right, but it can be covered in the documentation isn't it ? It would not be the first component to expose properties without effect depending on another properties' value.

[eps1lon]

That's right, but it can be covered in the documentation isn't it ?

Docs should have a warning as well, yes.

Though it is technically correct. Props are spread to the root element in both cases. One case just doesn't have on ;)

[oliviertassinari]

@fromi Thank you for opening this issue! I think that it's a great opportunity to take a step back and to reconsider what problem we wish this component to solve and how it fits into the global picture.

I have been wondering about removing this component in v5. Basically, developers could migrate way from this component.

1. Replace HiddenCss with the system. For instance:

<Hidden mdDown implementation="css"><A /></Hidden>

would turn into:

<Box display={{ xs: 'none', lg: 'block' }} /><A /></Box>

This is documented in https://material-ui.com/system/display/#hiding-elements and comes from prior-art in:

• https://getbootstrap.com/docs/4.4/utilities/display/#hiding-elements
• https://tailwindcss.com/docs/display/#app

2. Replace HiddenJs with useMediaQuery. For instance:

<Hidden lgUp implementation="js"><A /></Hidden>

would turn into:

const hidden = useMediaQuery(theme => theme.breakpoints.up('lg')))

return hidden ? null : <A />;

So in this context, I think that we could keep pushing forward in a direction that gets ride of Hidden. Meaning, a deprecation in v4 and removal in v5. What do you guys think?

[fromi]

I think it would cover every use cases. I was using HiddenCss to avoid a blinking issue with server side rendering, but the "Box display" way should do the same.

[0x636174]

for what it's worth, i vote to remove this 🤷‍♀️