Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rating] Allow different icons #18971

Closed
1 task done
jbromberg opened this issue Dec 24, 2019 · 2 comments · Fixed by #19004
Closed
1 task done

[Rating] Allow different icons #18971

jbromberg opened this issue Dec 24, 2019 · 2 comments · Fixed by #19004
Labels
component: rating This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@jbromberg
Copy link

jbromberg commented Dec 24, 2019 •
edited by oliviertassinari
Loading

Currently, we can change the icons of the rating element however it changes the icon of every single rating element. I would like to have unique rating icons for each rating.

  • I have searched the issues of this repository and believe that this is not a duplicate.

Examples 🌈

Motivation 🔦

I would like certain ratings to have different icons, such as noise level for example.
@mbrookes mbrookes added the component: rating This is the name of the generic UI component, not the React module! label Dec 24, 2019
@mbrookes
Copy link
Member

mbrookes commented Dec 24, 2019 •
edited
Loading

image

@oliviertassinari oliviertassinari added the new feature New feature or request label Dec 24, 2019
@oliviertassinari oliviertassinari changed the title [Rating] Allow different icons for each individual icon component [Rating] Allow different icons Dec 24, 2019
@hoop71 hoop71 mentioned this issue Dec 27, 2019
Merged
1 task
@hoop71
Copy link
Contributor

hoop71 commented Dec 27, 2019

@mbrookes @jbromberg how does this draft PR look? Does it address the need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: rating This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Rating] Add a demo with different icons hoop71/material-ui
4 participants
@mbrookes @oliviertassinari @hoop71 @jbromberg