[docs] Improve doc for textField and buttons #20207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DDDDDanica
commented
Mar 21, 2020
•
DDDDDanica
commented
- I have followed (at least) the PR section of the contributing guide.
DDDDDanica
changed the title
Details of bundle changes.Comparing: a55c30b...7312a9d Details of page changes
|
Co-Authored-By: Olivier Tassinari <olivier.tassinari@gmail.com>
| @@ -107,7 +107,7 @@ Here is an [integration example with react-router](/guides/composition/#button). | |||
|
|
|||
| ### Cursor not-allowed | |||
|
|
|||
| The ButtonBase component sets `pointer-events: none;` on disabled buttons, which prevents the appearance of a disabled cursor. | |||
| The `ButtonBase` component sets `pointer-events: none;` on disabled buttons, which prevents the appearance of a disabled cursor. | |||
There was a problem hiding this comment.
I believe that we didn't settle on a formating strategy for the components yet. There is a concern with the style of ``.
Suggested change
| The `ButtonBase` component sets `pointer-events: none;` on disabled buttons, which prevents the appearance of a disabled cursor. | |
| The ButtonBase component sets `pointer-events: none;` on disabled buttons, which prevents the appearance of a disabled cursor. |
There was a problem hiding this comment.
Hey @oliviertassinari not sure if i'm following you on this one. I noticed all the ButtonBase are decorated as code, and it felt like a bit inconsistency here. That's the reason behind this change. Let me if there's any concern or special case addressed for this one, i can revert it back :) Thx
There was a problem hiding this comment.
I'm glad you raise this consitency topic, I believe that if we take all the pages into account, it's highly inconsistent (50/50 usage split between these two forms). I wonder about what would be the best strategy.
There was a problem hiding this comment.
It used to be that the name of the UI pattern (e.g. 'expansion panel') was not formatted, but the name of the component ExpansionPanel was. I have no string preference whether it is or isn't formatted, once it's consistent.
There was a problem hiding this comment.
@mbrookes sounds great
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.