Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nav-button util #19

Open
wallace41290 opened this issue Jun 1, 2020 · 0 comments
Open

Refactor nav-button util #19

wallace41290 opened this issue Jun 1, 2020 · 0 comments
Assignees

Comments

@wallace41290
Copy link
Collaborator

Perhaps, but maybe that should go in a different PR. We might want to make it a little more generic too, it assumes there are all HTMLButtonElement, but I am going to use for the main <h1> in the top hero.

I also had a question about the button ripple initialization and if that should go here?

I think this should be a more generic, "smooth scroll" utility, doesn't have to be a button or could even be triggered programmatically...

Originally posted by @wallace41290 in https://github.com/_render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDQzMzI3MzcxOA==/comments/review_comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants