Skip to content

Commit

Permalink
update dependency for halo2 MsmAccel trait
Browse files Browse the repository at this point in the history
Replaces the dependency for the MSM acceleration layer to use the
version from the Privacy Scaling Explorations repo.

Still needs to depend on `halo2curves` explicitly, as
`halo2_middleware` does not reexport it.
  • Loading branch information
Vindaar committed May 6, 2024
1 parent f3e08ed commit 12f5686
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions constantine-rust/constantine-halo2-zal/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ repository = "https://github.com/mratsim/constantine"
[dependencies]
constantine-sys = { path = "../constantine-sys" }
constantine-core = { path = "../constantine-core" }
halo2curves = { git = 'https://github.com/taikoxyz/halo2curves', branch = "pr-pse-exec-engine" }
halo2_middleware = { git = 'https://github.com/privacy-scaling-explorations/halo2' }
halo2curves = { version = "0.6.1", default-features = false }

[dev-dependencies]
ark-std = "0.3"
Expand All @@ -22,7 +23,7 @@ rand_xorshift = "0.3"
rayon = "1.8"

# In CI "asm" needs to be disabled as some agents don't support ADX.
halo2curves = { git = 'https://github.com/taikoxyz/halo2curves', branch = "pr-pse-exec-engine" }
# halo2curves = { git = 'https://github.com/taikoxyz/halo2curves', branch = "pr-pse-exec-engine" }

[[bench]]
name = "msm"
Expand Down
2 changes: 1 addition & 1 deletion constantine-rust/constantine-halo2-zal/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use ::core::mem::MaybeUninit;
use std::mem;

use halo2curves::bn256;
use halo2curves::zal::MsmAccel;
use halo2_middleware::zal::traits::MsmAccel;
use halo2curves::CurveAffine;

#[derive(Debug)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use halo2curves::ff::Field;
use halo2curves::group::prime::PrimeCurveAffine;
use halo2curves::group::{Curve, Group};
use halo2curves::msm::best_multiexp;
use halo2curves::zal::MsmAccel;
use halo2_middleware::zal::traits::MsmAccel;

#[test]
fn t_threadpool() {
Expand Down

0 comments on commit 12f5686

Please sign in to comment.