-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mqttwarn does not like py39-paho-mqtt-2.0.0 #694
Comments
To be expected; paho mqtt has broken most programs with their 2.0; quite sad. I don’t think we’ve yet added support for it.
|
core.py:
|
Yes, Paho broke that very badly, and it affects hundreds of peoples' programs.
If you care to produce a PR we'll take it.
|
omg. Thanks for letting us know, and apologies for the late reply. We will take corresponding steps to remedy the problem in one way or another.
-- https://github.com/eclipse/paho.mqtt.python/releases/tag/v2.0.0 |
At least the dependency version pinning in project metadata is right. So, when package managers are taking them into account, nothing should break from one day to the other accidentally? Line 21 in e096289
NB: I am just trying to assess the seriousness and impact of the issue. @dlangille: Did you upgrade |
@dlangille: Relaying the error you reported....
... it probably relates to the topmost item from the v2.0.0 release notes: Caution BREAKING: Added callback_api_version. This breaks ALL users of paho-mqtt's Client class. See migrations.rst for details on how to upgrade. Fixing this sounds easy. |
Thoughts
References
Downstream
|
I've just submitted a patch to remedy the breaking change on the most prominent spot, based on learnings from mqtt-tools/pytest-mqtt#18. However, I don't think that patch will be accepted, as the authors seem to pretty strong about this detail? |
Hi. It looks like my patch might get accepted, helping users in basic use case scenarios to upgrade to Paho MQTT client version 2 without a breaking change. Naturally, it will not work in more advanced cases, as outlined by @PierreF on the same discussion. Thanks! |
It looks like paho-mqtt v2 is causing serious havoc throughout the community. That is natural with breaking changes, and apparently, much of what is behind is about the proper transitioning to support MQTTv5, which makes things different under the hood. However, I did not dig deeper, and, in this spirit, I am not able to evaluate the situation better than submitting that humble patch, and hoping for the best outcomes in the long run. That such an event feels annoying, is perfectly reasonable. However, sometimes such changes must happen, and all we can take away from that is that all users of packages should apply version pinning properly, in order not to run into such situations. In this case, |
For mqttwarn, I think it is sensible to wait for any further changes happen on paho-mqtt. Because mqttwarn is correctly applying the version pinning, I guess there is not much else to do at this point in time? Please let us know if you think differently. Line 21 in 9d61fc5
|
Have you tried 2.1.0? I did, yesterday, no luck for me. |
I've been unable to get
mqttwarn
to start today after updatingpy39-paho-mqtt
: 1.6.1 -> 2.0.0Reverting to 1.6.1 gets it running again.
Seem related to https://stackoverflow.com/questions/77984857/paho-mqtt-unsupported-callback-api-version-error?noredirect=1
The text was updated successfully, but these errors were encountered: