Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Services hosted libraries do not get the correct search path generated in the searchfox query for mobile applications #2248

Open
travis79 opened this issue Jun 28, 2024 · 0 comments

Comments

@travis79
Copy link
Member

Application Services library metrics links are broken because the metrics that are instrumented there aren't always called directly in the consuming application, so when I click on something like nimbus_events.exposure for either Firefox Android or iOS, I get the following links generated for the searchfox url:

nimbus_events.exposure on Firefox Android
https://searchfox.org/mozilla-mobile/search?q=nimbus_events.exposure|nimbusEvents.exposure|NimbusEvents.exposure|nimbus_events.exposure|nimbus_events::exposure&path=fenix&regexp=true

nimbus_events.exposure on Firefox iOS
https://searchfox.org/mozilla-mobile/search?q=nimbus_events.exposure|nimbusEvents.exposure|NimbusEvents.exposure|nimbus_events.exposure|nimbus_events::exposure&path=firefox-ios&regexp=true

Both of these should use the path application-services instead of the application search path, or both, in the case a metric might be instrumented in both the A-S library and the app.

Here's an example of a working searchfox query for the nimbus_events.exposure:

(with a path specified)
https://searchfox.org/mozilla-mobile/search?q=nimbus_events.exposure%7CnimbusEvents.exposure%7CNimbusEvents.exposure%7Cnimbus_events.exposure%7Cnimbus_events%3A%3Aexposure&path=application-services&case=false&regexp=true

(no path specified, still finds the metrics but could be less precise in certain cases)
https://searchfox.org/mozilla-mobile/search?q=nimbus_events.exposure|nimbusEvents.exposure|NimbusEvents.exposure|nimbus_events.exposure|nimbus_events%3A%3Aexposure&path=&case=false&regexp=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant