Update/merge Desktop/JS binding docs for tech review

[data-sync-user]

Existing docs updated, deprecated, linked and/or merged and ready for outside technical review of Desktop JS Bindings:

• UniFFI theory of operations doc
  • link to Travis’ vendoring doc
  • link/borrow pieces of Android api doc for observer bits
• ADR for UniFFI/Nimbus Firefox Desktop JS Bindings

The review and landings themselves will be tracked in other tickets, so some of the earlier comments here will be filed/tracked elsewhere..

┆Issue is synchronized with this Jira Task
┆Issue Number: SDK-19

[data-sync-user]

➤ Chelsea Lewis commented:

Leaving unassigned as this will be work done by an external team. Lina will keep track of this throughout the sprint.

[data-sync-user]

➤ Lina Cambridge commented:

The review packet so far:

• An ADR for front-end bindings ( https://docs.google.com/document/d/1XVBvjt52EKgaaAflMDqUGXQy2AK3sufgEFIu1ZjWbqw ), via WebIDL, XPIDL, js-ctypes, or Wasm.
• An ADR for C++ platform bindings ( https://docs.google.com/document/d/1kaVliEaNzhLthudBmWSJnmbyC70P0AQqNGE_4K0HYmI ).
• A prototype for front-end ( Generate Firefox Desktop front-end bindings with WebIDL uniffi-rs#255 ) bindings.

[data-sync-user]

➤ Nicholas Nethercote commented:

I've looked over the three parts of the review packet. Overall it looks good. The C++ proposal is straightforward. The JS proposal is still gnarly but that is unavoidable. I put some additional comments are in the Google Docs and the PR.

[data-sync-user]

➤ Lina Cambridge commented:

Thanks, @nnethercote! To close this issue out, I think we'll want to:

• Update the ADR to reflect that we're going with Option C for now. We can always revisit later.
• Bring Add S3 storage for storing media files #255 up to date with Nick's feedback, and get it reviewed and landed.
• Convert the Google Doc ADRs to Markdown, and move them into this repo.

After that's done:

• Build and link the Nimbus SDK on Desktop application-services#3571. Copy that ticket into a new Bugzilla bug and make a Phabricator patch to build the Rust Nimbus SDK and the generated bindings in Desktop. These can be Nightly-only to start with.
• Figure out the testing story. Start with a Nimbus xpcshell test, and maybe build a more elaborate testing strategy for generated bindings later (Figure out how to test generated UniFFI Desktop bindings uniffi-rs#272).

[rfk]

This is still open in our Jira, so re-opening here.

[data-sync-user]

➤ Daniel Mosedale commented:

Here is the updated Theory of Operations doc, which I've sent out for review:

https://docs.google.com/document/d/1JnSruKgfKDcfIuiMirEIhum4NOWYlo58sCXPoxtC21g/edit#heading=h.gug06n5739a

[data-sync-user]

➤ Daniel Mosedale commented:

Updated version of the ADR doc is at

https://docs.google.com/document/d/1wIb2ZOXn2RI75-GvicuuYbsYS-nqBAqMJxmVaePE3Wg/edit?usp=sharing ( https://docs.google.com/document/d/1wIb2ZOXn2RI75-GvicuuYbsYS-nqBAqMJxmVaePE3Wg/edit?usp=sharing )

The main changes here are just that I've incorporate a bunch of useful comments on the original doc from suggestions into the doc itself.

[data-sync-user]

➤ Daniel Mosedale commented:

Because the changes to the ADR doc weren't substantive, I don't think getting further review on it at this is likely to be very useful.