Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modern Electron releases #3701

Closed
dudewheresmycode opened this issue Nov 10, 2021 · 3 comments
Closed

Add support for modern Electron releases #3701

dudewheresmycode opened this issue Nov 10, 2021 · 3 comments

Comments

@dudewheresmycode
Copy link

Looking to integrate this project with Electron and I noticed you have some support, but the javascript package only provides prebuilt binaries up to Electron v11. However, the current supported releases of Electron are: v15.3.1, v14.2.1, v13.6.1 (https://releases.electronjs.org/)

I'm hoping the solution is as easy as adding additional versions to this line:
https://github.com/mozilla/DeepSpeech/blob/master/taskcluster/tc-all-vars.sh#L98

@reuben
Copy link
Contributor

reuben commented Nov 12, 2021

FWIW I've just updated the Coqui STT builds to cover newer NodeJS and ElectronJS versions over in coqui-ai/STT#2018

Should be available in npm soon, I'll trigger a new alpha version.

@rjstalb
Copy link

rjstalb commented Nov 18, 2021

I'm trying to get the nodejs binaries built against node versions but getting nowhere. Am I supposed to install electron manually or against a specific version? am I using the wrong node versions?

  • v10.4.0
  • v12.22.7
  • v14.18.1
  • v16.10.0

Output:
image

@ftyers
Copy link
Collaborator

ftyers commented Dec 1, 2021

Check out #3693.

@ftyers ftyers closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants