This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fixes #5179 - Alt text for homepage img tags #5180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punamdahiya
changed the title
|
Hold as we need to localize alt texts once test passes |
|
@6a68 With axe extension analyze , no errors shows up for img-alt @kimberlythegeek thoughts why npm run test:accessibility is failing for img-alt on home page |
punamdahiya
force-pushed
the
5179-img-homepage
branch
from
28b9cc1
to
17b1c53
Compare
punamdahiya
changed the title
|
@6a68 PR fixes accessibility tests on homepage. Thanks! |
flodolo
reviewed
Nov 15, 2018
| imgSettings = | ||
| .alt = Settings Icon | ||
| imgSignIn = | ||
| .alt = Sign In Icon |
There was a problem hiding this comment.
"Sign In" is a verb, "sign-in" is the noun, and I believe you want the latter in this context
There was a problem hiding this comment.
I think we should have empty alt strings here anyway since we have it on a the parent anchor
There was a problem hiding this comment.
Created #5181 to use empty alt text
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.