Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Shot page titles should include 'Firefox Screenshots' #3898

Closed
jaredhirsch opened this issue Dec 7, 2017 · 1 comment
Closed

Shot page titles should include 'Firefox Screenshots' #3898

jaredhirsch opened this issue Dec 7, 2017 · 1 comment
Assignees

Comments

@jaredhirsch
Copy link
Member

(Did we wontfix this bug already?)

From https://twitter.com/georgebaily/status/927520943903268864:

" hm, Firefox screenshot tool is cool and all, but setting the title as not just http://screenshots.firefox.com but also the page you screenshotted, means you get lots of false positives from browser history when typing a URL / bookmark "

@ghost ghost modified the milestones: Sprint 3 (59-2) 📥, Sprint 4 (59-3) 😯 Dec 18, 2017
@ianb ianb self-assigned this Jan 4, 2018
@ianb
Copy link
Contributor

ianb commented Jan 4, 2018

The <title> tag does include Screenshot:. Oddly the tab title and history title doesn't include this?

There are several title-like things on the page, including og:title, twitter:title. BUT: I believe the issue here is that we set document.title! That's not intentional.

@ianb ianb closed this as completed in 318c32e Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants