This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fix nsp error #3533
Merged
Fix nsp error #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…ing for now Followup to undo this in #3532
jaredhirsch
force-pushed
the
fix-nsp-error
branch
from
8f9dff6
to
13edc07
Compare
jaredhirsch
approved these changes
Sep 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got my branches a little off so there's some spurious commits, but I guess merging this will make it right again? Followup in #3532
The security issue is a Denial Of Service opportunity with tough-cookie and certain very large headers. It's possible that we already have long header blocking somewhere in our stack.