Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Saving to disk always downloads to ~/Downloads #3420

Closed
j605 opened this issue Aug 28, 2017 · 7 comments
Closed

Saving to disk always downloads to ~/Downloads #3420

j605 opened this issue Aug 28, 2017 · 7 comments
Labels
enhancement firefox Something that has to ship in the add-on in Firefox

Comments

@j605
Copy link
Contributor

j605 commented Aug 28, 2017

I have the preference "Always ask you where to save files" checked so I think it is intuitive that screenshots should also ask where it needs to be saved. If this is not possible, can you provide a way to set a different screenshot save location.

@johngruen johngruen added this to the Stretch milestone Aug 29, 2017
@ianb
Copy link
Contributor

ianb commented Aug 29, 2017

Note we just use the WebExtension download API. It has a saveAs flag, which would trigger the behavior you want, but I'm not sure how we can decide how to set that flag.

Well, looking a bit, I see browser.download.useDownloadDir is the underlying about:config pref. We could share this pref with the add-on via bootstrap.js the same way we share the Telemetry pref.

Arguably the WebExtension should be able to choose the right action on its own. I opened Bug 1394851 for this.

@jaredhirsch
Copy link
Member

@ianb What about using shift + click to trigger the "save as..." functionality, and regular click to save in the default spot?

@jaredhirsch
Copy link
Member

@johngruen
Copy link
Contributor

See also reddit thread here: https://www.reddit.com/r/firefox/comments/731m54/screenshots_is_shipping_in_firefox_56/dnnyqfj/

Regarding directory selection, the main reason I want to be asked where to save files is so that I can choose a different name for them.

This is a slightly different use case where the commenter want to name shots via their OS dialog on download.

@boomsya
Copy link

boomsya commented Oct 12, 2017

I want too change location folder for saving screens (because default folder on disk C:. I use primary SSD and i want to save screens on second HDD). Name of screen file it is no matter.
2 variants of this:

  1. always ask destination folder
  2. set folder in preferences

@ianb
Copy link
Contributor

ianb commented Jan 10, 2018

We should verify this in Nightly since the WebExtension bug has been closed.

@ianb ianb removed this from the Product Backlog milestone Jan 10, 2018
@ianb ianb added the firefox Something that has to ship in the add-on in Firefox label Jan 11, 2018
@SoftVision-CosminMuntean

I have retested these scenarios on latest Nightly 59.0a1 build and latest Beta 58.0b15 build. Here are the results:

  1. Always ask you where to save files" option is checked in "about:preferences#general" page
    When you download a selection/shot, a window which asks you where to save the file is displayed. After you choose a location and click the "Save" button, the selection/shot is correctly downloaded to the location.
    But, a "Download canceled by the user" error is displayed if you cancel the window which asks you where to save the file. I have logged a new issue for this: "Download canceled by the user" error is wrongly displayed when you cancel saving the selection to a specific location #3964

  2. Set a different folder where to save files in "about:preferences#general"
    The selection/shot is correctly downloaded in the chosen folder.

Besides of the new issue found, these scenarios work as expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement firefox Something that has to ship in the add-on in Firefox
Projects
None yet
Development

No branches or pull requests

6 participants