This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Protect against an empty response #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happened in some weird corner case while debugging
jaredhirsch
suggested changes
Jun 14, 2017
| } else if (result.type === "error") { | ||
| let exc = new Error(result.message); | ||
| } else if (result && result.type === "error") { | ||
| let exc = new Error(result.message || "Unknown error"); | ||
| exc.name = "BackgroundError"; | ||
| if ('errorCode' in result) { |
There was a problem hiding this comment.
I think you'll need to guard against result being undefined in these "foo" in result clauses, too. They'll throw if result is falsy.
There was a problem hiding this comment.
oh, we're inside a result && check here. Sorry!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened in some weird corner case while debugging