This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Remove embedded web extension in install manifest. #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes the embedded web extension to be parsed at startup, and triggers a race condition in existing Firefox code during startup on a clean profile between AddonManager and devtools code. Removing this is not an issue for Screenshots because it delays startup of the embedded web extension until "sessionstore-windows-restored" is observed anyway. See https://bugzilla.mozilla.org/show_bug.cgi?id=1356394 for more info.
|
@rhelmer gotta love the one-liner solution! thanks so much for digging into this last night |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasEmbeddedWebExtensioncauses the embedded web extension to be parsed when thebootstrapped extension is installed, which triggers a race condition in
existing Firefox code during startup on a clean profile between
AddonManager and devtools code.
Removing this is not an issue for Screenshots because it delays startup
of the embedded web extension until "sessionstore-windows-restored" is
observed anyway.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1356394 for more info.