Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

addon does not do anything on a page that is only a frameset #1748

Closed
copiousfreetime opened this issue Oct 14, 2016 · 1 comment
Closed

addon does not do anything on a page that is only a frameset #1748

copiousfreetime opened this issue Oct 14, 2016 · 1 comment
Assignees
@ianb
Milestone
Stretch

Comments

@copiousfreetime
Copy link

I tried to take a pageshot of a nagios status, and it appears that the addon has a problem with frameset based pages. Here's the html of the page in question:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Frameset//EN" "http://www.w3.org/TR/html4/frameset.dtd">

<html>
<head>
<meta name="ROBOTS" content="NOINDEX, NOFOLLOW">
<title>Nagios Core</title>
<link rel="shortcut icon" href="images/favicon.ico" type="image/ico">
</head>



<frameset cols="180,*" style="border: 0px; framespacing: 0px">
<frame src="side.php" name="side" frameborder="0" style="">
<frame src="main.php" name="main" frameborder="0" style="">

<noframes>
<!-- This page requires a web browser which supports frames. --> 
<h2>Nagios Core</h2>
<p align="center">
<a href="http://www.nagios.org/">www.nagios.org</a><br>
Copyright &copy; 2010-2016 Nagios Core Development Team and Community Contributors.
Copyright &copy; 1999-2010 Ethan Galstad<br>
</p>
<p>
<i>Note: These pages require a browser which supports frames</i>
</p>
</noframes>

</frameset>

</html>

A page that is just a frameset. I'm using Firefox 49.0.1 and have pageshot installed through test pilot. Upon clicking the frameset icon in the bar, nothing happened.
@ianb ianb added this to the Stretch milestone Oct 17, 2016
@ianb ianb self-assigned this Oct 18, 2016
@ianb
Copy link
Contributor

ianb commented Oct 18, 2016

Frame pages are more oddball than I expected, I guess that's why they were deprecated. We won't be able to support them but we are adding a check so that it will pop up a message.

@fzzzy fzzzy closed this as completed in 9aa7929 Oct 19, 2016
@ghost ghost mentioned this issue Nov 22, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ianb ianb

Labels
None yet
Projects
None yet
Milestone
Stretch
Development

No branches or pull requests
2 participants
@copiousfreetime @ianb