Fix #2569, put in a different icon when the user is not yet onboarded

mozilla-services · Apr 6, 2017 · f6fb476 · f6fb476
1 parent db23e98
commit f6fb476
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/addon/webextension/background/main.js b/addon/webextension/background/main.js
@@ -14,6 +14,9 @@ window.main = (function () {
 
   browser.storage.local.get(["hasSeenOnboarding"]).then((result) => {
     hasSeenOnboarding = !! result.hasSeenOnboarding;
+    if (! hasSeenOnboarding) {
+      setIconActive(false, null);
+    }
   }).catch((error) => {
     console.error("Error getting hasSeenOnboarding:", error);
   });
@@ -35,7 +38,10 @@ window.main = (function () {
   }
 
   function setIconActive(active, tabId) {
-    const path = active ? "icons/icon-highlight-38.png" : "icons/icon-38.png";
+    let path = active ? "icons/icon-highlight-38.png" : "icons/icon-38.png";
+    if ((! hasSeenOnboarding) && ! active) {
+      path = "icons/icon-38-starred.png";
+    }
     browser.browserAction.setIcon({path, tabId});
   }
 
@@ -178,6 +184,7 @@ window.main = (function () {
   communication.register("hasSeenOnboarding", () => {
     hasSeenOnboarding = true;
     catcher.watchPromise(browser.storage.local.set({hasSeenOnboarding}));
+    setIconActive(false, null);
   });
 
   return exports;

diff --git a/addon/webextension/icons/icon-38-starred.png b/addon/webextension/icons/icon-38-starred.png