Catch Watchdog upstream error. (#4871) (#4919)

mozilla-services · Sep 20, 2018 · e4bd0a5 · e4bd0a5
1 parent c3c6cb7
commit e4bd0a5
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/server/src/watchdog.js b/server/src/watchdog.js
@@ -274,6 +274,15 @@ exports.handleResult = function(req) {
       throw err;
     }
 
+    // Check if there was an upstream error at PhotoDNA.
+    // We leave the result as null.
+    if (req.body.error) {
+      const err = new Error(`Watchdog submission encountered an error at PhotoDNA.`);
+      err.watchdogSubmissionId = String(record.id);
+      err.photodnaResponseStatus = req.body.response.Status;
+      throw err;
+    }
+
     if (req.body.positive) {
       handlePositive(record);
     } else {