Refactor 'History enabled' checking code to clarify the expected bool…

…ean result
mozilla-services · Jan 24, 2018 · bc7b20a · bc7b20a
1 parent c8b1747
commit bc7b20a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/addon/bootstrap.js b/addon/bootstrap.js
@@ -230,7 +230,7 @@ function handleMessage(msg, sender, sendReply) {
       sendReply({type: "success", value: !!addon});
     });
     return true;
-  } else if (msg.funcName === "getHistoryPref") {
+  } else if (msg.funcName === "isHistoryEnabled") {
     let historyEnabled = getBoolPref(HISTORY_ENABLED_PREF);
     sendReply({type: "success", value: historyEnabled});
   } else if (msg.funcName === "incrementCount") {

diff --git a/addon/webextension/background/selectorLoader.js b/addon/webextension/background/selectorLoader.js
@@ -88,7 +88,7 @@ this.selectorLoader = (function() {
   // TODO: since bootstrap communication is now required, would this function
   // make more sense inside background/main?
   function downloadOnlyCheck(tabId) {
-    return communication.sendToBootstrap("getHistoryPref").then((historyEnabled) => {
+    return communication.sendToBootstrap("isHistoryEnabled").then((historyEnabled) => {
       return communication.sendToBootstrap("isUploadDisabled").then((uploadDisabled) => {
         return browser.tabs.get(tabId).then(tab => {
           let downloadOnly = !historyEnabled || uploadDisabled || tab.incognito;