fix disconnect button

mozilla-services · Aug 25, 2017 · 4332ac0 · 4332ac0
1 parent eac2f9e
commit 4332ac0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/server/src/pages/settings/controller.js b/server/src/pages/settings/controller.js
@@ -19,7 +19,7 @@ exports.disconnectDevice = function() {
       // FIXME: a lame way to do an error message
       window.alert("Error disconnecting: " + req.status + " " + req.statusText);
     } else {
-      location.href = model.backend + "/settings";
+      location.reload();
     }
   };
   req.send(`_csrf=${encodeURIComponent(model.csrfToken)}`);

diff --git a/server/src/pages/settings/view.js b/server/src/pages/settings/view.js
@@ -43,7 +43,7 @@ class Body extends React.Component {
           <div className="info-container">
             <p className="username title">{this.props.accountInfo.nickname || this.props.accountInfo.email}</p>
             { this.props.accountInfo.nickname ? <p className="email info">{this.props.accountInfo.email}</p> : null }
-            <a className="account-buttons disconnect" href="" onClick={ this.onClickDisconnect.bind(this) }>Disconnect</a>
+            <button className="account-buttons disconnect" onClick={ this.onClickDisconnect.bind(this) }>Disconnect</button>
           </div>
         </div>
       );

diff --git a/server/src/server.js b/server/src/server.js
@@ -677,7 +677,8 @@ app.post("/api/disconnect-device", csrfProtection, function(req, res) {
     let cookies = new Cookies(req, res, {keys: keygrip});
     if (result) {
       cookies.set("accountid");
-      res.redirect('/settings');
+      cookies.set("accountid.sig");
+      simpleResponse(res, "ok", 200);
     }
   }).catch((err) => {
     errorResponse(res, "Error: could not disconnect", err);