Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Foundation 6 #555

Closed
developer-lindner opened this issue Apr 21, 2017 · 5 comments
Closed

Support Foundation 6 #555

developer-lindner opened this issue Apr 21, 2017 · 5 comments

Comments

@developer-lindner
Copy link

Just stumbled upon this React Plugin and wondered if something like Foundation could be considered. Already tried to use FieldTemplate etc. but it's not that easy at all.

@glasserc
Copy link
Contributor

What's challenging about it?

I don't think anyone is opposed to other CSS frameworks, but we support Bootstrap because it's what we use. I'm a little nervous about adding support for specific CSS frameworks directly to this library when we don't support them. I'd much rather let people offer extensions that support whatever their favorite framework is. If there's something needlessly challenging about implementing those extensions as FieldTemplate bundles, I'd like to talk about that and maybe we can resolve it. I guess I'm not philosophically opposed to adding some other kind of hook to support CSS frameworks, but that would add complexity and I don't know what that hook would look like yet. Do you have any specific ideas?

@VojtaStanek
Copy link

HI!
I'm working with material design lite, but I am using this lib also. And in some cases the result is not that it does not have styles, but that it's unusable (e.g. buttons in array field are small and empty because I do not have the icon font).

Maybe if the UI would be separate from the logic and I would be able to supply some or even all UI components.

@glasserc
Copy link
Contributor

Hi @cactucs, the UI is already somewhat separated from the logic -- that's why we support e.g. custom widgets and fields. Is that not sufficient for what you need? Could you clarify what you'd like to see added or changed? It's true that ArrayField is of limited customizability right now -- I guess that's what #567 is about. I'd be willing to review patches to add customizability if we can do it cleanly without adding a lot of complexity.

@ztolley
Copy link

ztolley commented Jun 10, 2017

I like the sound of field template bundles. I want to use something that is more semantically correct than bootstrap to allow for better accessibility.

@epicfaace
Copy link
Member

Closing this in favor of #899.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants