-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Select by class instead of (multiple) id #1370
ui: Select by class instead of (multiple) id #1370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to add ${BaseComponent.count}
to the templates as well?
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
==========================================
+ Coverage 74.69% 74.79% +0.09%
==========================================
Files 127 127
Lines 6118 6118
Branches 854 854
==========================================
+ Hits 4570 4576 +6
+ Misses 1368 1363 -5
+ Partials 180 179 -1
Continue to review full report at Codecov.
|
Not really this was only needed for CSS rule for switch (for id). I could use the counter for the slider test, but I guess it thought just add confusion ( count ~= 6 ) and just use the hardcoded one ("slider"). But I can also share an other next change that introduce the counter just for unification of style of templates. |
@rzr It would make sense to me to be consistent. Can you push that change up to this PR? |
In case of multiple property of same types, UI events were forwarded to 1st instance of widget. This change is a follow up of the switch change: Origin: WebThingsIO#1370 Bug: WebThingsIO#1148 Relate-to: WebThingsIO#1249 Change-Id: I2018092168af14eb8f6f1e9e230e04a432490045 Signed-off-by: Philippe Coval <p.coval@samsung.com>
5a9ceda
to
4121248
Compare
This change has no real effect, only for making code more uniform, Note that slider id has been renamed to slider-level to remove ambiguity with slider, and counter suffix adjusted. Forwarded: WebThingsIO#1370 Change-Id: I64fe6a78a8ae9d300bab58561a7b0eec7bfb09db Signed-off-by: Philippe Coval <philippe.coval.pro@gmail.com>
4121248
to
df24dae
Compare
This change has no real effect, only for making code more uniform, Note that slider id has been renamed to slider-level to remove ambiguity with slider, and counter suffix adjusted. Forwarded: WebThingsIO#1370 Change-Id: I64fe6a78a8ae9d300bab58561a7b0eec7bfb09db Signed-off-by: Philippe Coval <p.coval@samsung.com>
@@ -128,6 +128,7 @@ class LevelPropertySection extends InputPropertySection { | |||
|
|||
async getValue() { | |||
const slider = await this.slider(); | |||
console.log(slider); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove log.
This change has no real effect, only for making code more uniform, Note that slider id has been renamed to slider-level to remove ambiguity with slider, and counter suffix adjusted. Forwarded: WebThingsIO#1370 Change-Id: I64fe6a78a8ae9d300bab58561a7b0eec7bfb09db Signed-off-by: Philippe Coval <p.coval@samsung.com>
df24dae
to
0c3ea5f
Compare
In case of multiple property of same types,
UI events were forwarded to 1st instance of widget.
This change is a follow up of the switch change:
Bug: #1148
Relate-to: #1249
Change-Id: I2018092168af14eb8f6f1e9e230e04a432490045
Signed-off-by: Philippe Coval p.coval@samsung.com