Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Select by class instead of (multiple) id #1370

Merged
merged 2 commits into from
Sep 25, 2018
Merged

ui: Select by class instead of (multiple) id #1370

merged 2 commits into from
Sep 25, 2018

Commits on Sep 24, 2018

  1. ui: Select by class instead of (multiple) id 

    In case of multiple property of same types,
UI events were forwarded to 1st instance of widget.

This change is a follow up of the switch change:

Origin: WebThingsIO#1370
Bug: WebThingsIO#1148
Relate-to: WebThingsIO#1249
Change-Id: I2018092168af14eb8f6f1e9e230e04a432490045
Signed-off-by: Philippe Coval <p.coval@samsung.com>
    @rzr
    rzr authored and Philippe Coval committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    6f04c38 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2018

  1. ui: Prevent duplicated id 

    This change has no real effect,
only for making code more uniform,

Note that slider id has been renamed to slider-level
to remove ambiguity with slider,
and counter suffix adjusted.

Forwarded: WebThingsIO#1370
Change-Id: I64fe6a78a8ae9d300bab58561a7b0eec7bfb09db
Signed-off-by: Philippe Coval <p.coval@samsung.com>
    @rzr
    rzr committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    0c3ea5f View commit details
    Browse the repository at this point in the history