Skip to content

Commit

Permalink
Remove some TODO's
Browse files Browse the repository at this point in the history
  • Loading branch information
henningkayser committed May 5, 2021
1 parent c2cceac commit 62a2020
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@
#pragma once

#include <Eigen/Geometry>
// TODO(henning) remove?
// #include <eigen_conversions/eigen_kdl.h>
#include <tf2_eigen/tf2_eigen.h>
#include <kdl/trajectory.hpp>
#include <moveit/robot_model/robot_model.h>
Expand Down
3 changes: 0 additions & 3 deletions moveit_planners/pilz_industrial_motion_planner/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@
<depend>moveit_core</depend>
<depend>moveit_ros_planning</depend> <!-- RobotModelLoader -->
<depend>moveit_ros_move_group</depend> <!-- move_group capability -->
<!-- TODO(henning): Remove?
<depend condition="$ROS_DISTRO != noetic">orocos_kdl</depend>
-->
<depend>liborocos-kdl-dev</depend>
<depend>pluginlib</depend>
<depend>rclcpp</depend>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,10 @@ CommandListManager::CommandListManager(const rclcpp::Node::SharedPtr& node,
// Obtain the aggregated joint limits
pilz_industrial_motion_planner::JointLimitsContainer aggregated_limit_active_joints;

// TODO(henning): pass PARAM_NAMESPACE_LIMITS
aggregated_limit_active_joints = pilz_industrial_motion_planner::JointLimitsAggregator::getAggregatedLimits(
node_, PARAM_NAMESPACE_LIMITS, model_->getActiveJointModels());

// Obtain cartesian limits
// TODO(henning): pass PARAM_NAMESPACE_LIMITS
pilz_industrial_motion_planner::CartesianLimit cartesian_limit =
pilz_industrial_motion_planner::CartesianLimitsAggregator::getAggregatedLimits(node_, PARAM_NAMESPACE_LIMITS);

Expand Down

0 comments on commit 62a2020

Please sign in to comment.