This repository has been archived by the owner on May 4, 2024. It is now read-only.
rename move-stdlib tests to match module names #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgao1996
approved these changes
May 20, 2022
There was a problem hiding this comment.
@tnowacki This fixes the specific case mentioned in #58, but as @jamesmeijers pointed out, does NOT address the general issue. I'll take a look at the package system and try to correct it there.
brson
pushed a commit
to brson/move
that referenced
this pull request
May 17, 2023
…ence. (move-language#153) The FunctionContext has grown organically over time and now contains an unwieldly collection of seven uplevel references to the enclosing ModuleContext-- including boxed function pointers needed during the function translation. This patch replaces all the uplevels with a single reference to the enclosing ModuleContext and updates all users. This will also simplify the passing of module-level structures (llvm::Context, llvm::Module) that are commonly needed in bundles, such as in the rttydesc module. A future patch will make those sorts of simplifications.
brson
pushed a commit
to brson/move
that referenced
this pull request
Jul 17, 2023
…ence. (move-language#153) The FunctionContext has grown organically over time and now contains an unwieldly collection of seven uplevel references to the enclosing ModuleContext-- including boxed function pointers needed during the function translation. This patch replaces all the uplevels with a single reference to the enclosing ModuleContext and updates all users. This will also simplify the passing of module-level structures (llvm::Context, llvm::Module) that are commonly needed in bundles, such as in the rttydesc module. A future patch will make those sorts of simplifications.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#58 #107
The test files ASCIIStringTests.move and OptionsTests.move were misnamed, their filename did not match the the module name within. This caused bug #58 . This is a quick fix, in the long run I don't think the system should not be assuming file names based on module names, even if naming conventions are suggested.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I tested it locally to ensure the bug was fixed.