Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The airbnb's installation script doesn't play nicely with CRA #34

Closed
petetnt opened this issue May 7, 2017 · 1 comment
Closed

The airbnb's installation script doesn't play nicely with CRA #34

petetnt opened this issue May 7, 2017 · 1 comment

Comments

@petetnt
Copy link
Member

petetnt commented May 7, 2017

The CRA installs eslint@^3.16.0, and when the airbnb installation script is run, it doesn't install eslint@3.19.0, leading to config errors (huh? breaking changes in minor updates?).

This is solved by running yarn add eslint@3.19.0 manually, but we should find a way do that anyways 🤔
@petetnt
Copy link
Member Author

petetnt commented May 17, 2017

Related:

We are working on getting 1.0 out but we never suggested using CRA with Airbnb config and don't officially support this. In fact I would discourage it because Airbnb is heavy on style rules, for which I suggest using Prettier instead. It’s fine if you do it, but there will be more issues like this, and unfortunately we can’t adjust our releases based on Airbnb releases. But yea, it is coming soon.

in facebook/create-react-app#2177

@petetnt petetnt mentioned this issue May 24, 2017
Merged
@petetnt petetnt closed this as completed May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petetnt