Enable correct resumption from the end of an epoch #700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR enables correct resumption from the end of an epoch. For example, suppose the dataset has 512 samples and I want to resume from sample 512. The intended behavior should be to detect that we are at the end of the epoch and start a new one. There were two small bugs preventing this from happening correctly:
orig
andrelaxed
) both threw an error whennum_samples <= drop_first
instead ofnum_samples < drop_first
. This means that if we wanted to create a sample partition of 512 samples but drop the first 512 samples, we would throw an error. This is not the right behavior -- we should return an empty sample partition instead.Manual run that had earlier failed, succeeding with these changes:
resumption-issue-testing-RnnDR4
Unit tests have been added for these cases.
Issue #, if available:
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)