Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[easy typo fix] fix f-string #596

Merged
merged 2 commits into from
Feb 8, 2024
Merged

[easy typo fix] fix f-string #596

merged 2 commits into from
Feb 8, 2024

Conversation

bigning
Copy link
Contributor

@bigning bigning commented Feb 8, 2024 •
edited
Loading

Run into this ValueError while working on something else, and realized it's missing f in the beginning of the string

@bigning bigning changed the title [easy] fix f-string [easy typo fix] fix f-string Feb 8, 2024
snarayan21
snarayan21 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just gonna wait for tests to pass, then feel free to merge.

@bigning bigning merged commit 7f5fba6 into main Feb 8, 2024
6 checks passed
@bigning bigning deleted the small_fix branch February 8, 2024 23:20
@knighton
Copy link
Contributor

knighton commented Feb 8, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 approved these changes

@knighton knighton Awaiting requested review from knighton

@karan6181 karan6181 Awaiting requested review from karan6181

@XiaohanZhangCMU XiaohanZhangCMU Awaiting requested review from XiaohanZhangCMU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigning @knighton @snarayan21