Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update misplaced params of _format_remote_index_files #584

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Update misplaced params of _format_remote_index_files #584

merged 1 commit into from
Feb 1, 2024

Conversation

lsongx
Copy link
Contributor

@lsongx lsongx commented Jan 29, 2024

Misplaced params:
_format_remote_index_files(cu.list_objects(), cu.remote)

Description of changes:

A quick fix of a small bug in #576
_format_remote_index_files(cu.list_objects(), cu.remote)
should be
_format_remote_index_files(cu.remote, cu.list_objects())

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

Misplaced params:
`_format_remote_index_files(cu.list_objects(), cu.remote)`
Copy link
Member

@XiaohanZhangCMU XiaohanZhangCMU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@XiaohanZhangCMU XiaohanZhangCMU merged commit cea06c1 into mosaicml:main Feb 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants