Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration test to include sample order comparison #456

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

karan6181
Copy link
Collaborator

Description of changes:

  • As part of testing streaming feature regularly to capture any regression, I had to add the below changes to make certain test working, such as.
    • Validating number of files locally
    • Validating the epoch iteration time
    • Validating the sample orders
  • More details is in PR https://github.com/mosaicml/testing/pull/43

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

regression/iterate_data.py Show resolved Hide resolved
regression/iterate_data.py Show resolved Hide resolved
regression/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just had some clarifying questions

@karan6181 karan6181 merged commit 8cc4fe0 into mosaicml:main Oct 4, 2023
6 checks passed
@karan6181 karan6181 deleted the integration branch October 4, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants