-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stratified Batching #408
Merged
snarayan21
merged 19 commits into
mosaicml:main
from
snarayan21:consistent_batch_composition
Sep 8, 2023
Merged
Stratified Batching #408
snarayan21
merged 19 commits into
mosaicml:main
from
snarayan21:consistent_batch_composition
Sep 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into consistent_batch_composition
karan6181
reviewed
Sep 6, 2023
karan6181
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the description with what all integration testing that you have run to validate this PR ?
karan6181
reviewed
Sep 7, 2023
karan6181
reviewed
Sep 7, 2023
karan6181
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank You!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR lets users control the composition of each batch. Previously, users could set proportions for streams, which would be fulfilled in aggregate over the whole training run. Now, users can have each batch also consistently be stratified between streams in specified proportions as well. This will help customers training multimodal models and can also make some fancier dataset mixing strategies possible. Users can access this functionality by setting
batching_method
tostratified
.How it works:
This is a useful feature that's good for multimodal applications and for some dataset mixing strategies. For example, we can combine text datasets with code datasets in definite proportions in every single batch, as long as the data is of the same dimension in each batch.
Ran multi-GPU tests with toy datasets to make sure that batches always had the same number of samples from each stream. Ran regression tests over 200 batches from different text datasets to ensure that elastic determinism and resumption still work when using
stratified
batching. These ran without issue and the results are here: https://wandb.ai/mosaic-ml/batching_methods/reports/new-batching-methods-testing--Vmlldzo1MzIxNjI1Issue #, if available:
https://mosaicml.atlassian.net/browse/STR-130
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)