Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a regression test for shuffling sample order #359

Merged
merged 10 commits into from
Aug 10, 2023

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Aug 2, 2023

Description of changes:

Add a regression test for shuffling sample order

Issue #, if available:

STR-91

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

@b-chu b-chu requested a review from karan6181 August 8, 2023 15:48
regression/deterministic_shuffling.yaml Outdated Show resolved Hide resolved
regression/iterate_data.py Outdated Show resolved Hide resolved
regression/deterministic_shuffling.yaml Outdated Show resolved Hide resolved
regression/deterministic_shuffling.yaml Outdated Show resolved Hide resolved
regression/deterministic_shuffling.yaml Outdated Show resolved Hide resolved
regression/deterministic_shuffling.yaml Outdated Show resolved Hide resolved
regression/deterministic_shuffling.yaml Show resolved Hide resolved
@b-chu b-chu requested a review from karan6181 August 8, 2023 21:26
@b-chu b-chu enabled auto-merge (squash) August 8, 2023 22:25
@b-chu b-chu requested a review from karan6181 August 9, 2023 14:44
@b-chu b-chu self-assigned this Aug 10, 2023
@b-chu b-chu merged commit 42c0c61 into mosaicml:main Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants