-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync tmp directory #316
Merged
Merged
Sync tmp directory #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karan6181
reviewed
Jun 27, 2023
… after the Stream is initialized
karan6181
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also try running the basic dataset iteration on more than 1 gpu (maybe 2, 4, or 8) multiple times with local=None
to ensure it works as expected.
knighton
reviewed
Jun 30, 2023
knighton
reviewed
Jun 30, 2023
b-chu
requested review from
knighton and
karan6181
and removed request for
bandish-shah and
knighton
July 3, 2023 15:53
knighton
reviewed
Jul 3, 2023
karan6181
approved these changes
Jul 18, 2023
b-chu
added a commit
to b-chu/streaming
that referenced
this pull request
Jul 18, 2023
* add venv to pyproject.toml * Fix style * Remove pyproject.toml changes * Remove pyproject.toml changes * Fix tests * Check for local directory * Fix tests * Add local_directory_timeout since download_timeout may be initialized after the Stream is initialized * Create folder after initializing timeout * Create folder before keep zip * Fix error message * Change wait and name for local directory creation * Change encryption for test and local directory * Fix tests * Fix tests * Add test for exception and move dist initialization * Change default to dict * Remove temp directory for default stream --------- Co-authored-by: Karan Jariwala <karankjariwala@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Use a temporary directory based on remote and split instead of a randomly created one so the same directory will be used in distributed training
Issue #, if available:
#293
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)