Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync tmp directory #316

Merged
merged 20 commits into from
Jul 18, 2023
Merged

Sync tmp directory #316

merged 20 commits into from
Jul 18, 2023

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Jun 27, 2023

Description of changes:

Use a temporary directory based on remote and split instead of a randomly created one so the same directory will be used in distributed training

Issue #, if available:

#293

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

streaming/base/stream.py Show resolved Hide resolved
streaming/base/stream.py Outdated Show resolved Hide resolved
streaming/base/stream.py Outdated Show resolved Hide resolved
@b-chu b-chu requested a review from karan6181 June 28, 2023 18:33
Copy link
Collaborator

@karan6181 karan6181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also try running the basic dataset iteration on more than 1 gpu (maybe 2, 4, or 8) multiple times with local=None to ensure it works as expected.

streaming/base/dataset.py Outdated Show resolved Hide resolved
streaming/base/stream.py Show resolved Hide resolved
streaming/base/stream.py Outdated Show resolved Hide resolved
streaming/base/stream.py Outdated Show resolved Hide resolved
streaming/base/stream.py Outdated Show resolved Hide resolved
streaming/base/stream.py Outdated Show resolved Hide resolved
tests/test_stream.py Show resolved Hide resolved
tests/test_stream.py Show resolved Hide resolved
streaming/base/stream.py Outdated Show resolved Hide resolved
streaming/base/stream.py Outdated Show resolved Hide resolved
@b-chu b-chu requested review from knighton and karan6181 and removed request for bandish-shah and knighton July 3, 2023 15:53
@b-chu b-chu requested a review from knighton July 14, 2023 16:13
@karan6181 karan6181 merged commit 137928c into mosaicml:main Jul 18, 2023
5 checks passed
b-chu added a commit to b-chu/streaming that referenced this pull request Jul 18, 2023
* add venv to pyproject.toml

* Fix style

* Remove pyproject.toml changes

* Remove pyproject.toml changes

* Fix tests

* Check for local directory

* Fix tests

* Add local_directory_timeout since download_timeout may be initialized after the Stream is initialized

* Create folder after initializing timeout

* Create folder before keep zip

* Fix error message

* Change wait and name for local directory creation

* Change encryption for test and local directory

* Fix tests

* Fix tests

* Add test for exception and move dist initialization

* Change default to dict

* Remove temp directory for default stream

---------

Co-authored-by: Karan Jariwala <karankjariwala@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants