Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix a very occasional hang in datasets map/filter #725

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Nov 9, 2023

Inspired by comments on this datasets issue huggingface/datasets#3172, I'm trying out removing lambdas.

Also adds some extra safety to first load and cache the tokenizer on local rank 0.

Test run: no-lambdas-1-nSBWMV
Loss still the same
Screenshot 2023-11-08 at 9 29 11 PM

Also opened an issue on datasets: huggingface/datasets#3172

@dakinggg dakinggg marked this pull request as ready for review November 9, 2023 05:33
@dakinggg dakinggg changed the title Attempt to fix a very occasional hang in datasets Attempt to fix a very occasional hang in datasets map/filter Nov 9, 2023
@dakinggg dakinggg enabled auto-merge (squash) November 9, 2023 05:56
@dakinggg dakinggg merged commit efaa545 into mosaicml:main Nov 9, 2023
12 checks passed
@dakinggg dakinggg deleted the datasets-bug branch December 11, 2023 23:44
@subercui
Copy link

subercui commented Apr 2, 2024

Hi, has this issue been resolved already? I encounters the same message as in huggingface/datasets#6393 . Running with datasets 2.16.0 and llm-foundry recently built from source

@dakinggg
Copy link
Collaborator Author

dakinggg commented Apr 3, 2024

If you're on llm foundry latest, it generally works fine. In very rare scenarios I have still hit the hang reported in that issue to huggingface datasets. If you're completely blocked, I'd recommend converting your dataset to our Streaming format and using that code path instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants