Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set eval shuffle to False #297

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Set eval shuffle to False #297

merged 2 commits into from
Jun 13, 2023

Conversation

eldarkurtic
Copy link
Contributor

I think eval dataloaders should not shuffle data for consistent evaluation results

bmosaicml pushed a commit that referenced this pull request Jun 8, 2023
@vchiley
add gc.collect to sgc (#297)
82aa1a6 
add gc collect to sgc
@abhi-mosaic abhi-mosaic self-requested a review June 13, 2023 16:42
abhi-mosaic
abhi-mosaic approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@abhi-mosaic abhi-mosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

I did a global ctrl-F and I think this is the only place we have this bug.

@abhi-mosaic abhi-mosaic merged commit 0ba87f7 into mosaicml:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi-mosaic abhi-mosaic abhi-mosaic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eldarkurtic @abhi-mosaic