Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore mosaicml logger for exception if excephook is active #1301

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Ignore mosaicml logger for exception if excephook is active #1301

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6c73ace
ignore logger if excephook is active
jjanezhang Jun 20, 2024
a0c8309
remove logger in data scripts and callback
jjanezhang Jun 24, 2024
cc53af3
undo format of imports
jjanezhang Jun 24, 2024
a45ec34
Merge branch 'main' into jane/add-excepthook-flag
dakinggg Jun 24, 2024
2f101e1
moved env var check into helper
jjanezhang Jun 24, 2024
ea82715
formatted
jjanezhang Jun 24, 2024
acd801d
removed import format
jjanezhang Jun 24, 2024
b43742b
Merge branch 'main' into jane/add-excepthook-flag
dakinggg Jun 24, 2024
03de031
added docstring
jjanezhang Jun 24, 2024
622ecdd
ran pre-commit
jjanezhang Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/train/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,8 @@ def main(cfg: DictConfig) -> Trainer:
except BaseContextualError as e:
if mosaicml_logger is not None:
e.location = TrainDataLoaderLocation
mosaicml_logger.log_exception(e)
if os.environ.get('OVERRIDE_EXCEPTHOOK', 'false').lower() != 'true':
mosaicml_logger.log_exception(e)
raise e

if mosaicml_logger is not None:
Expand Down Expand Up @@ -429,7 +430,9 @@ def main(cfg: DictConfig) -> Trainer:
except BaseContextualError as e:
if mosaicml_logger is not None:
e.location = EvalDataLoaderLocation
mosaicml_logger.log_exception(e)
if os.environ.get('OVERRIDE_EXCEPTHOOK',
'false').lower() != 'true':
mosaicml_logger.log_exception(e)
raise e

if mosaicml_logger is not None:
Expand Down
Loading