Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] use_remote_uploader_v2 #1237

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] use_remote_uploader_v2 #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da5059f
use_remote_uploader_v2
bigning May 24, 2024
25cdb7d
a
bigning May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llmfoundry/utils/config_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ class TrainConfig:
load_strict_model_weights: bool = True
load_ignore_keys: Optional[List[str]] = None
save_ignore_keys: Optional[List[str]] = None
use_remote_uploader_v2: bool = False

# Dataloader
device_train_microbatch_size: Union[str, int] = 'auto'
Expand Down
2 changes: 2 additions & 0 deletions scripts/train/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ def main(cfg: DictConfig) -> Trainer:
compile_config = train_cfg.compile_config
# Build the Trainer
log.info('Building trainer...')
log.info(f"bigning debug use remote uploader v2: {train_cfg.use_remote_uploader_v2}")
trainer = Trainer(
run_name=run_name,
seed=seed,
Expand Down Expand Up @@ -515,6 +516,7 @@ def main(cfg: DictConfig) -> Trainer:
save_num_checkpoints_to_keep=train_cfg.save_num_checkpoints_to_keep,
save_overwrite=train_cfg.save_overwrite,
save_weights_only=train_cfg.save_weights_only,
use_remote_uploader_v2=train_cfg.use_remote_uploader_v2,
load_path=train_cfg.load_path,
load_weights_only=train_cfg.load_weights_only,
load_strict_model_weights=train_cfg.load_strict_model_weights,
Expand Down
Loading