Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the system metrics logging frequency to reduce MLflow server's load #3436

Merged

Conversation

chenmoneygithub
Copy link
Contributor

What does this PR do?

Lower the system metrics logging frequency to reduce MLflow server's load. System metrics logging is using a different async logging queue from normal metrics, so the time buffering doesn't apply to system metrics. This design was by intention so that MLflow can terminate system metrics separately. 30s is the logging frequency of wandb, so there should be no user experience regression.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@chenmoneygithub chenmoneygithub requested a review from a team as a code owner June 28, 2024 05:43
@chenmoneygithub
Copy link
Contributor Author

@mvpatel2000 please let me know if you prefer to have it be a configurable argument, thanks!

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Every 30 seconds seems a bit infrequent... what about 10s?

@chenmoneygithub
Copy link
Contributor Author

@mvpatel2000 Thanks for reviewing! I am shortening the gap to 15s, which matches the wandb behavior: Lower the system metrics logging frequency to reduce MLflow server's load

@chenmoneygithub chenmoneygithub merged commit 57de2ea into mosaicml:dev Jun 28, 2024
14 checks passed
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
…load (mosaicml#3436)

* lower the system metrics logging frequency

* more frequent
mvpatel2000 pushed a commit that referenced this pull request Jul 21, 2024
…load (#3436)

* lower the system metrics logging frequency

* more frequent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants