Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Optionally use flash-attn's CE loss for metrics (#3394)" #3408

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Revert "Optionally use flash-attn's CE loss for metrics (#3394)" #3408

merged 1 commit into from
Jun 18, 2024

Conversation

snarayan21
Copy link
Contributor

This reverts commit 2cf9262. #3394

What does this PR do?

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 requested review from a team as code owners June 18, 2024 02:53
mvpatel2000
mvpatel2000 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting as this was causing daily test failures ahead of release CC: @bigning

.github/workflows/pr-cpu.yaml Show resolved Hide resolved
@snarayan21 snarayan21 enabled auto-merge (squash) June 18, 2024 03:10
@snarayan21 snarayan21 merged commit 08da687 into dev Jun 18, 2024
17 checks passed
@snarayan21 snarayan21 deleted the saaketh/revert_fa_ce_loss branch June 18, 2024 03:14
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
@snarayan21 @mvpatel2000
Revert "Optionally use flash-attn's CE loss for metrics (mosaicml#3394
18562ba 
)" (mosaicml#3408)

This reverts commit 2cf9262.

revert dat boi
mvpatel2000 pushed a commit that referenced this pull request Jul 21, 2024
@snarayan21 @mvpatel2000
Revert "Optionally use flash-attn's CE loss for metrics (#3394)" (#…
0a1a6a4 
…3408)

This reverts commit 2cf9262.

revert dat boi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snarayan21 @mvpatel2000