Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear caplog and use as context manager in test_logging #3382

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

snarayan21
Copy link
Contributor

What does this PR do?

To prevent other logs from polluting the logs captured in test_logging, calls caplog.clear() and uses it as a context manager instead.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg enabled auto-merge (squash) June 7, 2024 06:35
@dakinggg dakinggg merged commit ffbf163 into dev Jun 7, 2024
29 of 37 checks passed
@dakinggg dakinggg deleted the saaketh/caplog branch June 7, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants