Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ComposerModel output type #3341

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

hyenal
Copy link
Contributor

@hyenal hyenal commented May 29, 2024

What does this PR do?

This PR changes the output type of the ComposerModel. As long as the output type is a tensor, a tensor list, a dictionary of tensors or has a method cpu() (to satisfy this, note that if you return a list of non-tensors it will not break the pipeline) we should be able to return any type.

What issue(s) does this change relate to?

No issue has been opened yet.

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

cc: @JAEarly

@hyenal hyenal requested a review from a team as a code owner May 29, 2024 17:01
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it should be more arbitrary. Thanks for the PR!

@mvpatel2000 mvpatel2000 merged commit 57e7a08 into mosaicml:dev May 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants