Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cometml unit tests #3314

Merged
merged 2 commits into from
May 23, 2024
Merged

Fix cometml unit tests #3314

merged 2 commits into from
May 23, 2024

Conversation

j316chuck
Copy link
Contributor

@j316chuck j316chuck commented May 22, 2024

What does this PR do?

Fix comet ml unit tests

What issue(s) does this change relate to?

Fix failing unit tests seen in https://github.com/mosaicml/composer/actions/runs/9198261645/job/25301753094?pr=3264

@j316chuck j316chuck requested a review from a team as a code owner May 22, 2024 23:07
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix not pin

@j316chuck j316chuck changed the title Pin cometml version Fix cometml unit tests May 23, 2024
@j316chuck j316chuck enabled auto-merge (squash) May 23, 2024 17:16
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend

@j316chuck j316chuck merged commit 7f61ee6 into dev May 23, 2024
15 checks passed
@j316chuck j316chuck deleted the chuck/comet_pin branch May 23, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants