Fix UCObjectStore.list_objects #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
commented
May 13, 2024
irenedea
approved these changes
May 13, 2024
Co-authored-by: Irene Dea <deaairene@gmail.com>
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, the databricks SDK did not have
lsbuilt in, and we discovered a bug where we were not properly handling the truncation of thelsresults (truncated to 999 elements). This PR fixes that bug by switching over to the built inlsin the databricks SDK.Manual test, ran the convert to MDS script before and after, before it returns 999 elements, after it returns the full correct number (1350 from the directory I was testing)