Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wct save interval #3264

Merged
merged 51 commits into from
May 24, 2024
Merged

Wct save interval #3264

merged 51 commits into from
May 24, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented May 7, 2024

What does this PR do?

This PR attempts to support wall clock time as a interval metric. Users will be able to set wall clock time in training yamls to define their save interval. (https://docs.google.com/document/d/1zEs6YKN5YpnwQD-CXjyHlW7R98B3P8ORjEIqA5D8iwI/edit). Specifically, it introduces TimeUnit.SECOND, TimeUnit.MINUTE, TimeUnit.HOUR while keeping all time arithmetic in seconds (minutes and hours are converted to seconds).

manual test: wct-test-sec-v8msnl, wct-test-min-oUF2KU, wct-test-hr-A5zIE0

Checkpoints:
https://cloud.oracle.com/object-storage/buckets/axhe5a72vzpp/vincent-test/objects?region=us-phoenix-1
-->

What issue(s) does this change relate to?

N/A

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@KuuCi KuuCi marked this pull request as ready for review May 10, 2024 20:46
@KuuCi KuuCi requested a review from a team as a code owner May 10, 2024 20:46
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a PR description!

@KuuCi KuuCi enabled auto-merge (squash) May 11, 2024 23:11
@KuuCi KuuCi requested a review from mvpatel2000 May 13, 2024 17:31
@mvpatel2000 mvpatel2000 disabled auto-merge May 15, 2024 16:06
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were going to use train timestamp?

composer/utils/misc.py Outdated Show resolved Hide resolved
composer/core/time.py Outdated Show resolved Hide resolved
composer/core/time.py Outdated Show resolved Hide resolved
composer/core/time.py Outdated Show resolved Hide resolved
composer/core/time.py Outdated Show resolved Hide resolved
tests/test_time.py Outdated Show resolved Hide resolved
@KuuCi
Copy link
Contributor Author

KuuCi commented May 21, 2024

Working: wct-test-2m-UAMkGI
Broken Scheduler: wct-test-2m-xJkqik
Broken Max Duration: wct-test-2m-NupAgq

@KuuCi KuuCi requested a review from dakinggg May 21, 2024 06:27
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits

composer/core/time.py Outdated Show resolved Hide resolved
composer/core/time.py Show resolved Hide resolved
composer/core/time.py Outdated Show resolved Hide resolved
composer/optim/scheduler.py Outdated Show resolved Hide resolved
composer/trainer/trainer.py Outdated Show resolved Hide resolved
@KuuCi KuuCi requested a review from mvpatel2000 May 22, 2024 09:34
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! Final nit :)

composer/core/time.py Outdated Show resolved Hide resolved
composer/core/time.py Outdated Show resolved Hide resolved
composer/core/time.py Outdated Show resolved Hide resolved
composer/core/time.py Outdated Show resolved Hide resolved
@KuuCi KuuCi requested a review from mvpatel2000 May 24, 2024 21:26
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KuuCi KuuCi merged commit cf56030 into dev May 24, 2024
15 checks passed
@KuuCi KuuCi deleted the wct-save-interval branch May 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants